Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python 3 to 3.12 #18212

Merged
merged 30 commits into from
Sep 17, 2024
Merged

Bump Python 3 to 3.12 #18212

merged 30 commits into from
Sep 17, 2024

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Aug 6, 2024

What does this PR do?

Bump the Python version from py3.11 to py3.12

Motivation

https://datadoghq.atlassian.net/browse/AI-4081

Additional Notes

Docs PR: DataDog/documentation#24492

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@Kyle-Neale Kyle-Neale requested review from a team as code owners August 6, 2024 14:56
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@93a779a). Learn more about missing BASE report.
Report is 70 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory 72.72% <ø> (?)
activemq_xml 82.31% <ø> (?)
amazon_msk 88.84% <ø> (?)
ambari 85.80% <ø> (?)
apache 95.08% <ø> (?)
arangodb 98.23% <ø> (?)
argo_rollouts 90.00% <ø> (?)
argocd 87.81% <ø> (?)
aspdotnet 100.00% <ø> (?)
avi_vantage 91.35% <ø> (?)
aws_neuron 92.42% <ø> (?)
azure_iot_edge 82.08% <ø> (?)
boundary 100.00% <ø> (?)
btrfs 82.91% <ø> (?)
cacti 87.90% <ø> (?)
calico 84.61% <ø> (?)
cassandra 66.66% <ø> (?)
cisco_aci 94.93% <ø> (?)
citrix_hypervisor 87.50% <ø> (?)
cloud_foundry_api 96.11% <ø> (?)
cloudera 99.51% <ø> (?)
coredns 94.51% <ø> (?)
crio 89.79% <ø> (?)
datadog_checks_downloader 81.35% <ø> (?)
datadog_cluster_agent 90.19% <ø> (?)
dcgm 92.10% <ø> (?)
directory 95.03% <ø> (?)
disk 89.33% <ø> (?)
dns_check 93.29% <ø> (?)
druid 97.70% <ø> (?)
ecs_fargate 83.52% <ø> (?)
eks_fargate 94.05% <ø> (?)
external_dns 89.28% <ø> (?)
fluentd 84.32% <ø> (?)
fluxcd 88.31% <ø> (?)
fly_io 97.13% <ø> (?)
glusterfs 80.08% <ø> (?)
go_expvar 92.69% <ø> (?)
hive 51.42% <ø> (?)
hivemq 61.90% <ø> (?)
http_check 93.76% <ø> (?)
ibm_i 81.91% <ø> (?)
istio 77.86% <ø> (?)
jboss_wildfly 47.36% <ø> (?)
karpenter 95.06% <ø> (?)
kube_apiserver_metrics 97.74% <ø> (?)
kube_controller_manager 97.89% <ø> (?)
kube_dns 95.97% <ø> (?)
kube_metrics_server 94.87% <ø> (?)
kube_proxy 96.80% <ø> (?)
kube_scheduler 97.92% <ø> (?)
kubeflow 93.22% <ø> (?)
kubelet 91.01% <ø> (?)
kubernetes_cluster_autoscaler 93.22% <ø> (?)
kubernetes_state 89.50% <ø> (?)
kyototycoon 85.96% <ø> (?)
linux_proc_extras 96.22% <ø> (?)
mapr 82.35% <ø> (?)
marathon 83.12% <ø> (?)
mcache 93.50% <ø> (?)
mesos_master 89.75% <ø> (?)
mesos_slave 93.26% <ø> (?)
nagios 89.01% <ø> (?)
network 93.03% <ø> (?)
nfsstat 95.20% <ø> (?)
nginx_ingress_controller 98.55% <ø> (?)
nvidia_triton 88.52% <ø> (?)
openmetrics 98.06% <ø> (?)
php_fpm 89.71% <ø> (?)
postfix 88.04% <ø> (?)
presto 59.09% <ø> (?)
process 85.59% <ø> (?)
prometheus 94.17% <ø> (?)
pulsar 100.00% <ø> (?)
riak 99.21% <ø> (?)
riakcs 88.88% <ø> (?)
silk 93.82% <ø> (?)
singlestore 90.81% <ø> (?)
snowflake 96.27% <ø> (?)
statsd 87.36% <ø> (?)
supervisord 89.78% <ø> (?)
system_core 92.59% <ø> (?)
system_swap 98.30% <ø> (?)
tcp_check 90.39% <ø> (?)
teleport 99.61% <ø> (?)
tibco_ems 91.98% <ø> (?)
torchserve 97.32% <ø> (?)
traefik_mesh 76.75% <ø> (?)
traffic_server 96.13% <ø> (?)
twemproxy 79.56% <ø> (?)
twistlock 80.47% <ø> (?)
vllm 93.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kyle-Neale Kyle-Neale marked this pull request as draft August 6, 2024 15:17
@Kyle-Neale Kyle-Neale mentioned this pull request Aug 7, 2024
@Kyle-Neale Kyle-Neale force-pushed the kyleneale/bump_python_312 branch 2 times, most recently from 83757b3 to 8fd0064 Compare August 29, 2024 01:05
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

lu-zhengda
lu-zhengda previously approved these changes Sep 16, 2024
spencergilbert
spencergilbert previously approved these changes Sep 16, 2024
Copy link

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for ADEL owned files

zoedt
zoedt previously approved these changes Sep 16, 2024
apiazza-dd
apiazza-dd previously approved these changes Sep 16, 2024
crio/setup.py Outdated Show resolved Hide resolved
crio/setup.py Outdated Show resolved Hide resolved
iliakur
iliakur previously approved these changes Sep 17, 2024
datadog_checks_tests_helper/setup.py Outdated Show resolved Hide resolved
version = ["19.9", "20.1"]
python = ["3.12"]
# v22 of gunicorn is the first that supports python 3.12
version = ["22", "23"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wild, I thought we fixed this on master 🤯

@Kyle-Neale Kyle-Neale merged commit 69cffd9 into master Sep 17, 2024
528 of 543 checks passed
@Kyle-Neale Kyle-Neale deleted the kyleneale/bump_python_312 branch September 17, 2024 14:43
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
* bump py version to 3.12

* update dbm dev container

* update builders and build deps

* fix python string

* Build lxml dependencies for linux x64 (#18467)

* fix rmq version

* fix gunicorn tests

* Fix lock file generation

* comment out if clause to force dep resolution

* bump python to 3.12.6

* fix python on Windows sha

* remove DD_PYTHON2 unbound variable

* fix hatch errors

* remove setup.py files

* fix CI

* revert datadog_checks_test_helper

---------

Co-authored-by: Alex Lopez <[email protected]>
Co-authored-by: Ilia Kurenkov <[email protected]>
Co-authored-by: Alex Lopez <[email protected]> 69cffd9
@datadog-agent-integrations-bot
Copy link
Contributor

The backport to 7.58.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.58.x 7.58.x
# Navigate to the new working tree
cd .worktrees/backport-7.58.x
# Create a new branch
git switch --create backport-18212-to-7.58.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 69cffd9e02ffbdc3015294a2c39c9215c0df637a
# Push it to GitHub
git push --set-upstream origin backport-18212-to-7.58.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.58.x

Then, create a pull request where the base branch is 7.58.x and the compare/head branch is backport-18212-to-7.58.x.

Kyle-Neale added a commit that referenced this pull request Sep 27, 2024
* bump py version to 3.12

* update dbm dev container

* update builders and build deps

* fix python string

* Build lxml dependencies for linux x64 (#18467)

* fix rmq version

* fix gunicorn tests

* Fix lock file generation

* comment out if clause to force dep resolution

* bump python to 3.12.6

* fix python on Windows sha

* remove DD_PYTHON2 unbound variable

* fix hatch errors

* remove setup.py files

* fix CI

* revert datadog_checks_test_helper

---------

Co-authored-by: Alex Lopez <[email protected]>
Co-authored-by: Ilia Kurenkov <[email protected]>
Co-authored-by: Alex Lopez <[email protected]>
(cherry picked from commit 69cffd9)
Kyle-Neale added a commit that referenced this pull request Sep 30, 2024
* Bump Python 3 to 3.12 (#18212)

* bump py version to 3.12

* update dbm dev container

* update builders and build deps

* fix python string

* Build lxml dependencies for linux x64 (#18467)

* fix rmq version

* fix gunicorn tests

* Fix lock file generation

* comment out if clause to force dep resolution

* bump python to 3.12.6

* fix python on Windows sha

* remove DD_PYTHON2 unbound variable

* fix hatch errors

* remove setup.py files

* fix CI

* revert datadog_checks_test_helper

---------

Co-authored-by: Alex Lopez <[email protected]>
Co-authored-by: Ilia Kurenkov <[email protected]>
Co-authored-by: Alex Lopez <[email protected]>
(cherry picked from commit 69cffd9)

* fix build-deps.yaml

* Fix dependency build for macOS (#18581)

* Add workflow file to cache key on macos job

* Remove reference to DD_PYTHON2 which is no longer set

* Trigger the build in master when the workflow file changes

* remove changelog entries

---------

Co-authored-by: Alex Lopez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants